Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bool32 sometimes very difficult to use #35

Open
pjabardo opened this issue Jan 28, 2022 · 1 comment
Open

Bool32 sometimes very difficult to use #35

pjabardo opened this issue Jan 28, 2022 · 1 comment

Comments

@pjabardo
Copy link

Bool32 is defined as a 32 bit primitive but no methods of any kind are available so some functions that use this argument are difficult to use. Is there a specific reason for this? Couldn't Bool32 be defined as a Int32?

Replace the line in NIDAQ.jl
primitive type Bool32<:Integer 32 end

with
const Bool32 = Int32

Paulo

@bjarthur
Copy link
Collaborator

huh. good point. i don't remember the reason for that. have you tried it yourself and everything works? happy to review a PR. you'd want to make changes in these two places too:

https://github.com/JaneliaSciComp/NIDAQ.jl/blob/master/src/constants_V20.1.0.jl#L3685

https://github.com/JaneliaSciComp/NIDAQ.jl/blob/master/README.md?plain=1#L406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants