Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate runtime data layout performance #125

Closed
Ivorforce opened this issue Oct 10, 2024 · 1 comment
Closed

Investigate runtime data layout performance #125

Ivorforce opened this issue Oct 10, 2024 · 1 comment
Labels
feature New feature or request

Comments

@Ivorforce
Copy link
Owner

Ivorforce commented Oct 10, 2024

I've looked into this a bit. The relevant bit is here.

It uses a runtime bool to test for linear assignment, and constexpr for whether to use simd assignment. So far, so good.

We should still check if it actually does enter linear_assign sometimes.

@Ivorforce Ivorforce added the feature New feature or request label Oct 10, 2024
@Ivorforce Ivorforce changed the title Investigate runtime layout performance Investigate runtime data layout performance Oct 13, 2024
@Ivorforce
Copy link
Owner Author

I've gotten a bit further with this. #126 was fixed for array fills. I've also forked xtensor for xtensor-stack/xtensor#2810. I think this resolves the issue for now, since I've exhausted all spots where I think contiguous_layout is used (the static equivalent of is_contiguous). I've also opened PRs for all relevant spots in xtensor.

The only thing left to do now is to keep eyes open for potential similar pitfalls in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant