Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Reduce CSL version to 12.1.1 #2600

Closed
Ryun1 opened this issue Jan 5, 2025 · 0 comments · Fixed by #2601
Closed

💡 Reduce CSL version to 12.1.1 #2600

Ryun1 opened this issue Jan 5, 2025 · 0 comments · Fixed by #2601
Labels
🎨 Design Needed 💡 Feature idea Other area User Story Needed

Comments

@Ryun1
Copy link
Member

Ryun1 commented Jan 5, 2025 •
edited
Loading

Area

Other

Is there new design needed?

Yes

What?

  • Downgrade GovTool FE to use CSL 12.1.1

Why?

  • CSL 13.X forces the use of tag 258 sets in transactions (although in this era they are optional)
  • Bitbox02 hardware wallet does not support tag 258 sets and it is unlikely to soon, by downgrading GovTool we allow users of Bitbox to use GovTool
  • I have tested using 12.x CSL with Ledger, Keystone and Trezor, and all good (to be expected)

How?

npm i @emurgo/[email protected]

(Optional) User Story with acceptance criteria

No response
MSzalowski added a commit that referenced this issue Jan 6, 2025
@MSzalowski
chore(#2600): reduce CSL version to 12.1.1
0d0336e
@MSzalowski MSzalowski mentioned this issue Jan 6, 2025
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Jan 6, 2025 that will close this issue
chore(#2600): reduce CSL version to 12.1.1 #2601
Merged
5 tasks
MSzalowski added a commit that referenced this issue Jan 7, 2025
@MSzalowski
Merge pull request #2601 from IntersectMBO/chore/2600-reduce-csl-vers…
3fd1c7e 
…ion-to-1211

chore(#2600): reduce CSL version to 12.1.1
@github-project-automation github-project-automation bot moved this from In Progress to Done in Governance Tools Community Backlog Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 Design Needed 💡 Feature idea Other area User Story Needed
Projects
Governance Tools Community Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(#2600): reduce CSL version to 12.1.1 IntersectMBO/govtool
1 participant
@Ryun1