-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of temporal type and operators #316
Comments
Using the threeten-extra (additional date-time classes that complement those in Java SE 8.) the mapping can be as follow: date -> java.time.Instant This simplify the parsing of ISO_8601 format. |
Test case:
The truncated representation of period is left unimplemented as it seems to be deprecated
|
The temporal functions are defined in the grammar as follow:
Turning normal function invocations into special case with untyped parameters. |
In order to handle time_agg, the group all needs to be implemented. The group all only supports one expression. This is surprising as one might want to use other expressions to adjust the groups (contat, split, math, etc) |
Even worse, what should be the name of the new column that the group all uses? Using convention here requires evaluating the expression itself. |
Type system:
Notes:
The manual points out that the time is the root time, and represents time interval (
start
,end
). It should support shift, mutation of start / end values, split and so on.The date is defined as a time with
start = end
.The time period is a "non-overlapping time interval" with a "regular duration". The regular duration is only relevant for months (varying number of days) and days (timeshifts). It seems the intent is to represent duration in time, such as 2018W1 (first week of 2018) or 2020Q1 (first quarter of 2020).
The text was updated successfully, but these errors were encountered: