Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing episodes of a series is not possible #7

Open
Ingo-FP-Angel opened this issue Jan 2, 2024 · 3 comments
Open

Playing episodes of a series is not possible #7

Ingo-FP-Angel opened this issue Jan 2, 2024 · 3 comments
Labels
bug Something isn't working partly fixed Some fix implemented, final solution still open

Comments

@Ingo-FP-Angel
Copy link
Owner

Ingo-FP-Angel commented Jan 2, 2024

In v1.0.3 it is not possible to play single episodes (only movies work).

From the exception in the log it looks like the result of requests.get(f'https://api.tenant.frontend.vod.filmwerte.de/v11/{lm4utils.getSetting("tenant")}/movies/{videoId}/uri',headers=headers) is not proper JSON

Or maybe the movies part of the URL is wrong

@Ingo-FP-Angel Ingo-FP-Angel added the bug Something isn't working label Jan 2, 2024
@frie
Copy link

frie commented Jan 2, 2024

My observation was that "not proper JSON" in fact is an empty result string, caused by a 404 response to the http request.

@frie
Copy link

frie commented Jan 2, 2024

Or maybe the movies part of the URL is wrong

When replacing movies by episodes the plugin plays the episode (but no movies longer when just putting this into the code...). Probably there will be some way to tell the function how to build the correct URL.

@Ingo-FP-Angel
Copy link
Owner Author

v1.0.4 implements kind of a hack, because playing a video (currently) just passes its ID but not the meta data to the playback function (which would allow to distinguish the type of entry).

For now the plugin first requests video details as movie and if that returns a 404 it tries again as episode

@Ingo-FP-Angel Ingo-FP-Angel added the partly fixed Some fix implemented, final solution still open label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working partly fixed Some fix implemented, final solution still open
Projects
None yet
Development

No branches or pull requests

2 participants