Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plants model to use pyrealm flora definition #659

Open
davidorme opened this issue Jan 7, 2025 · 0 comments
Open

Update plants model to use pyrealm flora definition #659

davidorme opened this issue Jan 7, 2025 · 0 comments

Comments

@davidorme
Copy link
Collaborator

davidorme commented Jan 7, 2025

The implementation of the plant functional types and the Flora object in the Plants Model are cut down placeholders for the more complex definition that is now implemented in pyrealm (as of 2.0.0-rc.1). We need to:

  • Switch the Flora implementation over to pyrealm

  • Think about how to configure the PFT definitions.

    This is actually a bit tricky: these are currently part of the TOML model configuration, but that is increasingly unpleasant for large numbers of PFTs and the set of traits expanded beyond the current placeholder of name and max height. The cleanest way is to provide a CSV dataframe, which pyrealm already supports, and add a PFT file path to the configuration.

@davidorme davidorme added this to the Plant Model Development milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant