pop sound plays more than once at a high framerate

[Novaenia]

steps to reproduce:

1. uncap your framerate
2. get enough frames
3. go swimming

[IllagerCaptain]

When you say more than once, do you mean twice, three times, every frame? It's hard for me to test this particular issue myself because my computer is a potato.

[Novaenia]

it sounds like a new instance of the pop sound is being made every frame that a bubble's half-popped sprite is visible

[pajicadvance]

This most likely happens because playSound is called in a mixin to a rendering method which runs every frame.

BetterBubbles/src/client/java/com/betterbubbles/mixin/client/InGameHudMixin.java

Line 58 in cd9dec5

if (z == s && playerEntity.isSubmergedIn(FluidTags.WATER)) {

This condition is probably true during multiple frames so the sound plays once for each frame. You need to somehow make sure that the sound only plays in the first frame when the condition is true and not in the frames that come after.