Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for header logo with text / tab title #7

Open
dnsmichi opened this issue Apr 10, 2019 · 2 comments
Open

Add example for header logo with text / tab title #7

dnsmichi opened this issue Apr 10, 2019 · 2 comments

Comments

@dnsmichi
Copy link

Coming from Icinga/icingaweb2#3093 I'd like to suggest an example for either:

  • Logo with company name enhanced
  • Tab title setting (if possible)

I've seen that with Discourse themes, having such as an example tremendously helps the main product :)

Cheers,
Michael

@Thomas-Gelf
Copy link

Regarding the browser title: this would require us to make the "Application Name" configurable, right now this is stored in a Constant. And: if implemented, this would be a setting in config.ini, would this fit your use-case? Reading the application name from a theme would have a notable (and not acceptable) performance impact.

"Logo with company name" is more an esthetic issue. It would waste space and/or look ugly. I usually create variants of the company logo, with different accents like a "testing" badge/banner, helping to distinct different instances. Of course, "text" would be a lot easier for people not used to creating images for the web.

@dnsmichi
Copy link
Author

Ad tab title: Yes, definitely, thanks. The most simplest and fast way, I don't want to push this too much.

Ad logo title: I know about the text concerns vs the logo with an embedded text. Since this theme holds best practices and examples, I'm totally fine with a CSS entry which is commented out, just pushing users towards the right direction :)

Cheers,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants