-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Director Labels in Monitoring Module Custom Vars section #2239
Comments
For reference |
Just to add a wish from my side because I like the idea very much, but I have one small concern. For debugging I sometimes need the real values and because of this I hated the behaviour of rewriting Icinga Web 2 had in the past. So I would suggest an additional hover effect which shows something like "Label [Key]" or to stick with the given example "Paris [par]" and "Barcelona [bcn]". |
Now with data field categories it would be great to have not only get the fields but also the categories in the monitoring module. Bonus points for the categories then being collapseable and having them hideable for non-administrative users. |
The entire custom variable section is collapsible. I see no point in allowing more fine-grained control over this.
That's what blacklists and protections are for. There's the visibility setting for string datafields, which will be respected, but no additional restriction layer. |
Icinga DB Web will show the raw custom variables in the |
ref/NC/734495 |
Well, never mind. They will be collapsible. |
Expected Behavior
Custom vars added to a host via Icinga Director employ the key defined in Director but not the label which is what Director displays in all its forms. For consistency and because labels tend to be more human-friendly I'd like to have Director override this behaviour.
It will be enough to have it as an optional setting.
Current Behavior
If we create a data list in Director such as.
Example Data List "Location":
Key / Label
bcn / Barcelona
lon / London
par/ Paris
We can now assign a "Location" value to a host selecting from a dropdown (Barcelona, London, Paris) and that label will be what all that you see in Director templates/host forms/etc....
However in the monitoring module when you click on the host you will see that the custom var "location" has the value "bcn/lon/par" which is not ideal particulary because there is no easy way to rename existing keys without deleting/readding.
Possible Solution
In Icinga Insights chat there was a suggestion that there is a hook on the monitoring module that will allow Director to override the usage of keys for labels.
Steps to Reproduce (for bugs)
Your Environment
icinga2 --version
):2.12The text was updated successfully, but these errors were encountered: