Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the way how profile views are tracked #22

Open
algomaster99 opened this issue Jul 13, 2020 · 1 comment
Open

Enhance the way how profile views are tracked #22

algomaster99 opened this issue Jul 13, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@algomaster99
Copy link
Member

Whenever a detail view of a team/alumni is opened, a view counter is incremented in the back-end. But there is some problem with its implementation as of now as it is not the best way and seems more like hack.

When one clicks the profile, an entry in the localStorage is created with key as the handle of the maintainer and value as the timestamp. This is done because the component is usually mounted 3 times so it sends 3 PUT requests which increment the counter by 3. This hack, thus, checks the time of "last visit" and if it is more than 5 seconds, only then it shall increment.

Screenshot from 2020-07-13 19-22-40

Obviously a better implementation is needed. 😛

@algomaster99 algomaster99 added enhancement New feature or request help wanted Extra attention is needed labels Jul 13, 2020
@rochakjain361
Copy link

I would like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants