Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using + to compose strings instead of u''.format #35

Open
ErwinJunge opened this issue Oct 22, 2017 · 3 comments
Open

Using + to compose strings instead of u''.format #35

ErwinJunge opened this issue Oct 22, 2017 · 3 comments

Comments

@ErwinJunge
Copy link
Contributor

The code uses + to compose strings instead of using the modern python standard of u''.format
There are also some instances of % formatting.

We should convert all of the above to use u''.format.

https://docs.python.org/2/library/stdtypes.html#str.format

@iulyaav
Copy link

iulyaav commented Oct 24, 2017

May I work on this?

@rohithasrk
Copy link
Contributor

@Iuliaav There are already two pull requests corresponding to this issue. So, I think there is no point in duplicating efforts. You can work on some other issues in the repository. Check them out 😃

@iulyaav
Copy link

iulyaav commented Oct 25, 2017

@rohithasrk Cool, thanks. I'll take a look at the other issues, see what needs a helping hand ^.^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants