You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Filter station.data() by product ('co2' for example).
Go through the code and check for strings that need to be added to constants.
Licence by pid is available from the metadata store. Check it out by sparqling any pid. License should be fetched from the metadata store and should not be set as a fixed string.
Automation of pylib. (🌿 $git checkout tests locally for Zois)
Test automation (pytest)
Force coding styles (flake8)
Automate distribution to PyPI (GitHub workflows, actions, e.t.c) (tox)
Zois & Claudio have both worked on this. No issue has yet been published.
Switch nominatim to something lighter independent of release (Probably make a card for this)
Include automation (see point below) (Learn how to automate)
Implement as webservice with docker.
Minimal python
Shapefiles
More info on slack.
Anders's comments/ideas
There are several function calls of the pylib with the parameter ‘project’. Some of this code is implemented only for ‘project’ = ‘ICOS’ (which is fine), but some are related to 'NEON', 'INGOS' or, 'FLUXNET' which is confusing for a user who might compare the pylib to the data portal (which, by the time of writing, has these seven projects: European ObsPack, GCP, ICOS, InGOS, Miscellaneous (Various other data not associated with a specific project), SOCAT, Swedish National Network).
Should we clarify or explain this somehow?
Some improvement suggestions for the Station object, of icoscp.station:
The Station object has the property products. By default products() returns a pandas DataFrame (provided the station object has ‘data’), but it can deliver a dictionary, (which is just the dataframe converted into a dictionary with the key 0 (zero), and then products(‘dict’)[0] is a dictionary), a better choice would be to return:
A dictionary with useful keys. In the atmospheric case (we could have other implementations for ES, OS): product labels with sampling heights like: {'Atmospheric CO2 product': [2.5, 8, 33, 60, 150], 'ICOS ATC CO2 Release': [2.5, 10, 30, 60, 150],...}
Just a list with labels instead of a data-frame
The Station object could have a method get_dobj() with parameters doi or a product-key, where the product-key, in the case of 'AS' could be a tuple like (‘ICOS ATC CO2 Release’, 60).
icoscp.station.fmap() – if provided a dataframe with product data, we could give much more specific info on the station – e.g. if the product_df contains the column 'samplingheight', 'height' or 'depth'. This could be displayed on the map. Here is an example where I renamed the column 'samplingheight' to 'elevation'
The text was updated successfully, but these errors were encountered:
See here which tasks were included in release 0.1.18
cpb
module.station.data()
by product ('co2' for example).$git checkout tests
locally for Zois)Should we clarify or explain this somehow?
products
. By defaultproducts()
returns a pandas DataFrame (provided the station object has ‘data’), but it can deliver a dictionary, (which is just the dataframe converted into a dictionary with the key 0 (zero), and then products(‘dict’)[0] is a dictionary), a better choice would be to return:{'Atmospheric CO2 product': [2.5, 8, 33, 60, 150], 'ICOS ATC CO2 Release': [2.5, 10, 30, 60, 150],...}
get_dobj()
with parametersdoi
or aproduct-key
, where theproduct-key
, in the case of 'AS' could be a tuple like(‘ICOS ATC CO2 Release’, 60)
.icoscp.station.fmap()
– if provided a dataframe with product data, we could give much more specific info on the station – e.g. if the product_df contains the column'samplingheight'
,'height'
or'depth'
. This could be displayed on the map. Here is an example where I renamed the column'samplingheight'
to'elevation'
The text was updated successfully, but these errors were encountered: