Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 47 #141

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Issue 47 #141

wants to merge 20 commits into from

Conversation

anna-riesch
Copy link
Contributor

Providing a config file to set and store gWhisper cli parameter values

Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
@anna-riesch anna-riesch marked this pull request as ready for review August 29, 2022 10:32
src/CMakeLists.txt Show resolved Hide resolved
target_link_libraries ( ${TARGET_NAME}
PRIVATE
reflection
protoDoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think none of those linked libs are needed

protoDoc
)
target_link_libraries ( ${TARGET_NAME}
PUBLIC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only last two deps needed?

src/gWhisperSetting/CMakeLists.txt Outdated Show resolved Hide resolved
return setting;
}

// Ersetze ParseTree beim Suchen -> f_parseTree.findFirstChild
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

german comment

src/gWhisperSetting/GWhisperSetting.cpp Outdated Show resolved Hide resolved
src/libCli/Call.cpp Outdated Show resolved Hide resolved
src/libCli/Call.cpp Outdated Show resolved Hide resolved
src/libLocalDescriptorCache/DescDbProxy.cpp Outdated Show resolved Hide resolved
@@ -0,0 +1,13 @@
{
"configParameter": {
"Ssl": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "Ssl": null here?


}

void gWhisperSettings::retrieveConfigParameters(json &f_startElement){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not used anymore

std::string findParameterSettingInConfig(const std::string &f_parameter, const json &f_startLayer);

json m_config;
std::vector<std::string> m_configParameters;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration files - At least for output formatting options (colors)
2 participants