-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 47 #141
base: master
Are you sure you want to change the base?
Issue 47 #141
Conversation
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
Signed-off-by: Anna Riesch <[email protected]>
src/gWhisperSetting/CMakeLists.txt
Outdated
target_link_libraries ( ${TARGET_NAME} | ||
PRIVATE | ||
reflection | ||
protoDoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think none of those linked libs are needed
src/gWhisperSetting/CMakeLists.txt
Outdated
protoDoc | ||
) | ||
target_link_libraries ( ${TARGET_NAME} | ||
PUBLIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only last two deps needed?
return setting; | ||
} | ||
|
||
// Ersetze ParseTree beim Suchen -> f_parseTree.findFirstChild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
german comment
@@ -0,0 +1,13 @@ | |||
{ | |||
"configParameter": { | |||
"Ssl": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "Ssl": null here?
Signed-off-by: Anna Riesch <[email protected]>
|
||
} | ||
|
||
void gWhisperSettings::retrieveConfigParameters(json &f_startElement){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not used anymore
std::string findParameterSettingInConfig(const std::string &f_parameter, const json &f_startLayer); | ||
|
||
json m_config; | ||
std::vector<std::string> m_configParameters; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
Providing a config file to set and store gWhisper cli parameter values