Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible choice in completion disappears #14

Open
rainerschoe opened this issue Mar 6, 2019 · 2 comments
Open

Possible choice in completion disappears #14

rainerschoe opened this issue Mar 6, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@rainerschoe
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
./gwhisper 127.0.0.1 some.service ReadF + TAB still shows ReadFile ReadFileProperties ReadFanBut after adding an "i" I getReadFile`
as completion.

subsequent tabs complete as if "ReadFile" was selected.

@rainerschoe rainerschoe added the bug Something isn't working label Mar 6, 2019
@rainerschoe
Copy link
Member Author

OK After detailed analysis I traced this down to several problems of the Grammar Injector and all elements calling it.

  1. Grammar injector did parse grammar for a candidate first then the other candidate/winner continued parsing with the wrong grammar from the previous candidate. I temporarily fixed this by always injecting new grammar on each parse.
  2. Grammar injector did not have enough information for injecting grammar for some candidates (i.e. from a concat child). I did not fix this, but it is not really visible

I reverted the fix for 1 again due to huge performance impact on slow network connections. Need to find a better solution.

this is still a problem. However it merely affects auto-completion the tool is still usable in those scenarios by explicitly typing the previously suggested name.

@rainerschoe
Copy link
Member Author

behavior improved after fixing [#25]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant