Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitECS: Add a UI to opt-in the new loader #6342

Closed
takahirox opened this issue Oct 19, 2023 · 1 comment
Closed

bitECS: Add a UI to opt-in the new loader #6342

takahirox opened this issue Oct 19, 2023 · 1 comment
Labels
enhancement work that enhances an existing feature new-loader P1 Address as quickly as possible

Comments

@takahirox
Copy link
Contributor

takahirox commented Oct 19, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Room-level new loader enable flag has been introduced. But to turn it on we need to run fetchReticulumAuthenticated() on the console after sign-in. The way to turn it on is very tedious.

We are thinking of shipping the new loader code to Hubs cloud and managed instances and disabling it by default. Adding a UI to opt-in the new loader is useful for users who want to try the new loader.

Describe the solution you'd like

Add an UI to toggle the new loader. Maybe at Room settings would be good that allows room owners to enable/disable the new loader.

image

When it's toggled call fetchReticulumAuthenticated(). Also, ideally let all client in the room reload the page when it's toggled.

Additional context

Related: #6337 #6325

We may think of enabling the new loader by default on demo hubs while disabling it by default on hubs cloud and managed hubs.
@takahirox takahirox added enhancement work that enhances an existing feature P1 Address as quickly as possible new-loader labels Oct 19, 2023
@takahirox takahirox changed the title bitECS: Add a way to opt-in the new loader bitECS: Add a UI to opt-in the new loader Oct 19, 2023
@takahirox takahirox mentioned this issue Oct 19, 2023
Closed
@takahirox
Copy link
Contributor Author

Closing to merge with #6325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement work that enhances an existing feature new-loader P1 Address as quickly as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@takahirox