Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasionally the orange presence icon gets "stuck on" #79

Open
mqp opened this issue Aug 13, 2019 · 1 comment
Open

Occasionally the orange presence icon gets "stuck on" #79

mqp opened this issue Aug 13, 2019 · 1 comment

Comments

@mqp
Copy link
Contributor

mqp commented Aug 13, 2019

Not sure what might be causing this. It doesn't seem to happen often, but it definitely happened once; the last person left, and the icon remained there. There must be some kind of race condition, or perhaps some case in which the bot fails to recognize "itself" and thinks that the room is still occupied because the bot is in it.

@mqp
Copy link
Contributor Author

mqp commented Dec 20, 2019

Here's my final word on this:

A) The bug is fixed when you bridge and re-bridge the room in question. That means that the error is probably related to the bridging or presence state, not to the Discord channel name cache or anything that discord.js or the Discord API is doing.
B) However, if you do !hubs users in the affected room, it shows that the presence state accurately represents nobody in the room. (Except the bot, which it is accurately filtering out.) This is almost identical to what it does to determine whether to put the orange diamond there.
C) This leaves a very small surface area to contain the bug. Some kind of race condition that I have failed to imagine is likely.

For now, I disabled the check against the current discord.js-cached channel name, making the room for errors even smaller, if the bug persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant