-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection Probes import support #125
Comments
There are a couple of issues when importing back reflection probe nodes.
Seems to me that the simplest way forward would be to move the reflection probe Blender object info into the component and allow adding the component to any object. The only properties that we are using are clip_start and clip_end so it shouldn't be a lot of info to add to the output glTF file. |
Yeah the main point of reflection probes using the Blender reflection probe objects was for their useful gizmos. Since we now have support for custom gizmos I think we want to move it to a proper component on an empty. We will have to do this eventually anyway since we want to add additional properties like a capture offset, box projection size, etc. Re importing in general though, I feel like it should be fairly low priority especially for things not supported in Spoke, since that's the main real usecase I can see for needing to import a gltf with component data in it. Nice to have full parity outside of just migrating out of Spoke eventually, but I suspect the amount of people who actually end up using that instead of just passing around .blend files to be pretty small. |
I agree on moving the params to the component and letting this be added to any object. On the import size, actually I saw the cloud sync being the major use case for it. Right now the Blender workflow it very tied to Spoke but eventually would be nice to have full Blender/Cloud integration and for that to be bi-directional we need glTF import support (ie. remixing avatar/scenes or iterating over them) |
This is already in the importer but we agreed on reverting it. |
Description
Reflection probes are currently imported as empties.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The text was updated successfully, but these errors were encountered: