You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This create an issue with some (all?) bootstrap theme, since the color for top and bottom may be different.
You may think at first that this is an uncommon scenario, but it is not; that's because bootstrap use border-top: 0; to hide the top border, and this will actually translate to border-top-width: 0px; border-top-style: initial; border-top-color: initial;: in the end, the sort ascending has "border-color" and sort descending has "color".
I see two possibile soution to this issue. One is to explicitely set the color to a default value, which may be initial to be consistent with the font. The other is to use UTF-8 characters ▼ and ▲ as after/before pseudo-selector content, avoiding the issue completely.
What do you think?
The text was updated successfully, but these errors were encountered:
This naturally inherits the color of the parent th (plus it uses ems instead of px so it scales properly). I also removed the float: right because it looked weird having the caret way off to the side on wide columns.
In the theme sass file, the sort handle icon is set as follow:
This create an issue with some (all?) bootstrap theme, since the color for top and bottom may be different.
You may think at first that this is an uncommon scenario, but it is not; that's because bootstrap use
border-top: 0;
to hide the top border, and this will actually translate toborder-top-width: 0px; border-top-style: initial; border-top-color: initial;
: in the end, the sort ascending has "border-color" and sort descending has "color".I see two possibile soution to this issue. One is to explicitely set the color to a default value, which may be
initial
to be consistent with the font. The other is to useUTF-8
characters ▼ and ▲ as after/before pseudo-selector content, avoiding the issue completely.What do you think?
The text was updated successfully, but these errors were encountered: