Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular imports #1339

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Fix circular imports #1339

merged 4 commits into from
Aug 16, 2024

Conversation

AlecAivazis
Copy link
Collaborator

Fixes #1304

This PR fixes the circular imports that in the generated runtime

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: 640a31a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-adapter-static Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 640a31a
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/66bf04e2ea5cc0000822f1b4

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 640a31a
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66bf04e25c95ca00085e9a52

@AlecAivazis AlecAivazis merged commit 98859e7 into main Aug 16, 2024
15 checks passed
@AlecAivazis AlecAivazis deleted the circular-imports branch August 16, 2024 07:54
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
endigma pushed a commit to endigma/houdini that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependencies in $houdini folder
1 participant