Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the function sdf2weights in scene_rep.py #30

Open
heyicheng-never opened this issue Aug 29, 2023 · 0 comments
Open

About the function sdf2weights in scene_rep.py #30

heyicheng-never opened this issue Aug 29, 2023 · 0 comments

Comments

@heyicheng-never
Copy link

Thanks for your work. In the function sdf2weights, if all the predicted SDF values of a ray are positive, the inds of the ray is 0 since the the mechanism of torch.argmax() that if all inputs are the same value, 0 will be output.
inds = torch.argmax(mask, axis=1)
So the corresponding z_min will be the config["cam"]["near"]. When the predicted SDF is all positive, it should indicates the z_min should be infinite, which makes me confused. What's more, this will make the elements in acc_map in function raw2output always equal 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant