Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private clipboard support separated from system's clipboard #306

Open
ghost opened this issue Dec 2, 2023 · 4 comments · May be fixed by #687
Open

Private clipboard support separated from system's clipboard #306

ghost opened this issue Dec 2, 2023 · 4 comments · May be fixed by #687
Labels
contributor needed There will not be any progress without someone volunteering to work on this enhancement New feature or request low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities

Comments

@ghost
Copy link

ghost commented Dec 2, 2023

As the title says, implementing a private clipboard seperated from system would be very helpful when copying some sensitive info. It is already there in FlorisBoard and I use it when copying some sensitive texts or passwords along with OpenBoard for general typing.
Please consider this. Thank you.

@ghost ghost added the enhancement New feature or request label Dec 2, 2023
@ghost ghost changed the title Private clipbord support separated from system's clipboard Private clipboard support separated from system's clipboard Dec 2, 2023
@Helium314 Helium314 added the low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities label Dec 10, 2023
@Helium314 Helium314 added the PR Contributors are encouranged to submit a pull request. Just ask in case you are interested. label Jan 8, 2024
@Helium314 Helium314 added contributor needed There will not be any progress without someone volunteering to work on this and removed PR Contributors are encouranged to submit a pull request. Just ask in case you are interested. labels Feb 1, 2024
@Helium314
Copy link
Owner

Since text can be copied by the app to the clipboard only via the copy button, a simple solution would be adding a "private copy" button that just puts the text into the internal clipboard.

@codokie
Copy link
Contributor

codokie commented Apr 1, 2024

@Helium314 I think I should be able to add a toggle in Preferences (near "Enable clipboard history") to make the "copy" button copy text to the internal clipboard as part of #611

@Helium314
Copy link
Owner

I think it would be better to have two copy buttons (normal and private), because this allows the user to choose when copying without having to go to the settings.

E.g. when copying sensitive data a user might want to use the private copy button that does not use the system's clipboard.
But when copying a URL they might want to allow the browser to access the clipboard and thus use the normal copy button.

@codokie codokie linked a pull request Apr 12, 2024 that will close this issue
@Helium314
Copy link
Owner

As a short summary: a private clipboard is wanted for copying sensitive info.
So far not much more info provided, and no feedback on the proposed implementations, thus it's hard to understand what is actually wanted, so the more suitable of the 2 proposed implementations can be used.

My proposal

  • A toolbar key that only copies into internal clipboard, but not into system clipboard. Since we now also have a cut key, that would mean 2 keys.
  • advantages
    • users can choose on the fly (for each copy) whether they want to copy to system clipboard or only to internal clipboard by using the respective button
  • disadvantages
    • 2 more toolbar keys available (private cut, private copy)
    • means at least one more key in the toolbar for users who want to regularly use both private copy and normal copy via toolbar
    • if another toolbar key with copy function is added, it would need to get a private alternative as well

@codokie's proposal

  • One setting whether an item copied to the system clipboard should end up in the clipboard history, and another setting whether text copied or cut using the toolbar keys should also be copied to the system clipboard.
  • advantages
    • users have the option to copy to system clipboard only, but not the internal one (not sure why someone would want this though)
    • when setting to copy to private clipboard, users can still copy / cut to system using the menu when long pressing the text
  • disadvantages
    • 2 more settings and also more work for translators
    • users cannot simply choose to use "the other" copy, but need to enter settings first (if user default is private, they can work around this using the long press menu. but if users would like this, then nobody would have wanted a copy key)

Anything I missed above?
Any feedback / opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor needed There will not be any progress without someone volunteering to work on this enhancement New feature or request low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants