Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level_cmd_load_model_from_geo and process_geo_layout should have debug assertions #570

Closed
thecozies opened this issue Jan 20, 2023 · 0 comments · Fixed by #722 or #738
Closed

level_cmd_load_model_from_geo and process_geo_layout should have debug assertions #570

thecozies opened this issue Jan 20, 2023 · 0 comments · Fixed by #722 or #738
Assignees
Labels
enhancement New feature or request medium priority Semi-important issue or feature / medium priority
Milestone

Comments

@thecozies
Copy link
Contributor

thecozies commented Jan 20, 2023

level_cmd_load_model_from_geo checks if the model you're loading is less than the model id count, but should throw an assertion if DEBUG Addressed: #722

also, when iterating the geolayout in in process_geo_layout , the first command should be verified to not be a bogus entry, iirc the only valid nodes would be GEO_CULLING_RADIUS (if an object geolayout this is fine) or GEO_NODE_START, there may be others im not thinking of, but this assertion would be for attempting to load a geolayout that doesnt exist. (it could just be in a different object group or whatever). the errors that this causes are really hard to track down because its likely that you would call way outside of the limit of GeoLayoutJumpTable

@thecozies thecozies added enhancement New feature or request medium priority Semi-important issue or feature / medium priority labels Jan 20, 2023
@gheskett gheskett added this to the 3.0 milestone Mar 6, 2023
@gheskett gheskett modified the milestones: 3.0, 2.2 Sep 27, 2023
@someone2639 someone2639 self-assigned this Oct 4, 2023
@gheskett gheskett modified the milestones: 2.2, 2.1.X Dec 16, 2023
@gheskett gheskett linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Semi-important issue or feature / medium priority
Projects
None yet
3 participants