Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling macro2md coupling per face #88

Open
6 tasks
Thinkpiet opened this issue Jan 8, 2025 · 0 comments
Open
6 tasks

Add support for disabling macro2md coupling per face #88

Thinkpiet opened this issue Jan 8, 2025 · 0 comments
Assignees

Comments

@Thinkpiet
Copy link
Member

The current indexing system initialization code assumes that the MD domain is embedded in the CFD domain, i.e. that we want to couple macro-to-md on each of the 6 faces of the Mamico domain. TODO: allow disabling of coupling per face.

Suggested XML format in <mamico> config to configure this:
<enable-macro-to-md west="yes" east="no" north="no" south="no" bottom="no" top="no" />

Steps:

  • Allow mamico config to read enable-macro-to-md tag
  • Make the entire enable-macro-to-md tag optional
  • Default option is west="yes" east="yes" north="yes" south="yes" bottom="yes" top="yes"
  • Pass boundary infos to a new initialization method for IndexingService
  • Configure the IndexTrait::md2macro domain via CellIndex::lowerBoundary and CellIndex::upperBoundary so that it includes the outerRegion at the faces where enable-macro-to-md is "no"
  • Add unit test for new IndexingService initialization method, I guess this should simply be based on a few hardcoded examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants