Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity? #39

Open
niksy opened this issue Oct 4, 2021 · 1 comment
Open

Activity? #39

niksy opened this issue Oct 4, 2021 · 1 comment

Comments

@niksy
Copy link

niksy commented Oct 4, 2021

I wanted to ask about this package activity.

  • There are no tests so it isn’t clear how close this package matches the spec. Would you consider accepting PR which uses tests from node-url so we can be closer to implementation which majority of Webpack users is using?
  • Node has added few new methods to core url API such as fileURLToPath. It would be nice to have these methods available in this package.
  • Since ESM has gained traction, it would be nice to have proper exports in package.json.

I would be willing to create PRs for this if this package is still maintained and reviewed, but from what I currently see, there isn’t any new activity.

@louisremi
Copy link

Hi @niksy ,
I was frustrated of the inactivity of the repo but I needed this package in a TS repo, so I forked it to another repo: https://github.com/louisremi/portable-url
I've already merged the two pending PRs of this repo and I'm welcoming new PRs
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants