-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple tabs stuck on 2FA don't refresh after authentication is done #2
Comments
Wouldn't this also be the case when the current session is expired? So not just when 2FA is needed? |
When a session expires, it'll redirect you to the login screen where the extension does its job. (gets called on these URLs) I think it would be redundant to refresh all (uGent related) background tabs once the session expires, as you're not even using them anyways... |
In my experience I sometimes just get a popup that mentions the fact that I have been inactive for too long (at least it did for me when I came back from class haha). It then gives the option to either log back in or something else which i forgot. |
Issue:
When multiple tabs are open and 2FA is required on the login screens, all (uGent related) tabs will be stuck at 2FA to be filled in.
After one of the tabs has completed 2FA, the others still have to be manually refreshed to "notice" that the 2FA was completed.
(this is from what I can remember, it's hard to force 2FA to test this)
Potential Fix:
Once one 2FA has been completed, the other tabs should refresh automatically.
=> call some function which refreshes all the other tabs stuck at 2FA login screens.
Or redirect the "stuck" tabs to their "target" URL after 2FA is done on one of them.
The text was updated successfully, but these errors were encountered: