Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple tabs stuck on 2FA don't refresh after authentication is done #2

Open
GoddeerisEdouard opened this issue Nov 5, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@GoddeerisEdouard
Copy link
Owner

GoddeerisEdouard commented Nov 5, 2024

Issue:
When multiple tabs are open and 2FA is required on the login screens, all (uGent related) tabs will be stuck at 2FA to be filled in.
After one of the tabs has completed 2FA, the others still have to be manually refreshed to "notice" that the 2FA was completed.

(this is from what I can remember, it's hard to force 2FA to test this)

Potential Fix:
Once one 2FA has been completed, the other tabs should refresh automatically.
=> call some function which refreshes all the other tabs stuck at 2FA login screens.
Or redirect the "stuck" tabs to their "target" URL after 2FA is done on one of them.

@GoddeerisEdouard GoddeerisEdouard added the enhancement New feature or request label Nov 5, 2024
@emiledeloof
Copy link
Contributor

Wouldn't this also be the case when the current session is expired? So not just when 2FA is needed?

@GoddeerisEdouard
Copy link
Owner Author

GoddeerisEdouard commented Nov 5, 2024

Wouldn't this also be the case when the current session is expired? So not just when 2FA is needed?

When a session expires, it'll redirect you to the login screen where the extension does its job. (gets called on these URLs)
There are no issues with sessions expiring without 2FA being required.

I think it would be redundant to refresh all (uGent related) background tabs once the session expires, as you're not even using them anyways...
Only once you're using an expired (session) background tab again & you're browsing in it, will it redirect to the login screen.
Or did you have other use cases/issues in mind?

@emiledeloof
Copy link
Contributor

In my experience I sometimes just get a popup that mentions the fact that I have been inactive for too long (at least it did for me when I came back from class haha). It then gives the option to either log back in or something else which i forgot.

@GoddeerisEdouard
Copy link
Owner Author

GoddeerisEdouard commented Nov 5, 2024

In my experience I sometimes just get a popup that mentions the fact that I have been inactive for too long (at least it did for me when I came back from class haha). It then gives the option to either log back in or something else which i forgot.

If you're referring to the element that sometimes appears from the bottom where "you haven't moved in 300(?) seconds" on Ufora which has a link to "log in in a new window": it's a security measure. The pop-up also explains that it's specifically there for security purposes: in case a student forgot to log out on a shared computer. Preventing that time-out isn't recommended.

Just clicking the "log in in a new window" button will open the login screen, which this extension automates. - yes, you still have to manually click the "log in in a new window" link.

I'm not sure if this inactive "pop-up" appears on every Ufora tab & if it goes away automatically once there has been logged in through one tab... (it does)
afbeelding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants