Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API v1.0 not supported #28

Open
simonihmig opened this issue Jun 26, 2015 · 7 comments
Open

JSON API v1.0 not supported #28

simonihmig opened this issue Jun 26, 2015 · 7 comments

Comments

@simonihmig
Copy link

This library says it supports the JSON API specs, but as it seems not the current standard v1.0, or am I missing something?

According to the standard the primary resource should be put under the "data" key, but this implementation puts it under a key named like the resource type (see https://github.com/GoIntegro/hateoas/blob/master/JsonApi/DocumentSerializer.php#L83).

Other specs like putting resource fields under a "attributes" key, or using the "included" key to put related resources, seem to be not supported as well. So in general the JSON format seems to differ from the spec v1.0 substantially!

Which version is it based on then? Does not seem to be mentioned, and when is v1.0 support to be expected, if at all?

@silverqx
Copy link

I'm interesting about this too.

@skqr
Copy link
Contributor

skqr commented Jun 29, 2015

Hey, guys!

Ex-main dev here. I did write this about a year ago, pre-v1. I forked the spec around that time, so here's the version I was working against.

I'm not currently working at GOintegro, so I couldn't say about the plans they have for updating the lib, but I'll get in touch with them, see if I can get the ball rolling.

We do have an issue open on the Symfony Bundle repo about it, but it doesn't seem it has gotten much attention yet.

Thanks for the interest!

@simonihmig
Copy link
Author

@skqr Thanks for your feedback, hope to see this coming. Maybe I can help here, at least with testing...

@bedes
Copy link

bedes commented Jul 8, 2015

Hi Guys. I was really excited to get this up and running quickly and think it's really neat. However, similar to @simonihmig, as soon as I attempted to POST I realized it doesn't conform to JSONAPI v1.0. There also seems to be an issue with the json-schema parsing. Now that v1.0 is the final spec I'd love to start requesting our clients use it.

@drewclauson
Copy link

@skqr like the others, I'm interested in using this with v1.0 - did you hear anything back from GoIntegro?

@silverqx
Copy link

@drewclauson
Copy link

@szachara Thanks, I have looked over it but was just considering whether to go that route, which seems like it's pretty early in development or wait to see if GoIntegro updates. I'm pretty far down the Symfony/Doctrine/FOSRest path and there seems to be a lot of support for it, so I'll probably jump on that bandwagon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants