Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator configDiscovery.validate is returning data instead of if data is valid or not #385

Open
christian-hawk opened this issue Nov 14, 2021 · 0 comments
Assignees

Comments

@christian-hawk
Copy link
Contributor

Right now the configuration validator is returning the configuration data if data is valid. This is not validator responsability.

validate() should be void (return nothing if success, throw error if invalid) or a boolean if valid (in that case name should be isValid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants