Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): enable dialog for password which is not following rule #1593

Open
mzico opened this issue Feb 29, 2024 · 3 comments · Fixed by #1613
Open

feat(admin-ui): enable dialog for password which is not following rule #1593

mzico opened this issue Feb 29, 2024 · 3 comments · Fixed by #1613
Assignees
Labels
comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request

Comments

@mzico
Copy link
Contributor

mzico commented Feb 29, 2024

We have a feature that can validate strong password policy.
This is how we enable it.

In TUI, upon enabling strong password policy, no user can create simple password. TUI throw error like below:
Screenshot from 2024-02-29 12-11-12

We would like to throw such type of error message from Admin-UI as well.

@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Feb 29, 2024
@duttarnab
Copy link
Contributor

Hi @pujavs

re: https://github.com/JanssenProject/jans/blob/main/jans-config-api/plugins/docs/user-mgt-plugin-swagger.yaml

The APIs in OpenApi specs do not have an error response body. The Admin UI is not able to display the error from APIs due to this reason. Could you please check and advise.

image

@duttarnab duttarnab changed the title feat(admin-ui): Enable dialog for password which is not following rule feat(admin-ui): enable dialog for password which is not following rule Mar 8, 2024
duttarnab added a commit that referenced this issue Mar 8, 2024
duttarnab added a commit that referenced this issue Mar 8, 2024
feat: enable dialog for password which is not following rule #1593
@mzico
Copy link
Contributor Author

mzico commented Mar 25, 2024

@duttarnab : i am reopening the issue. Seems like we are unable to modify any other attribute in Admin-UI when this password validation is applied.

Meaning:

  • Enabled password validation.
  • Created an user with new password policy. It's saved.
  • Now if we want to modify any other attribute for that user, it's not possible.

Here is a GIF:

Unable_to_modify_other_attributes

@mzico mzico reopened this Mar 25, 2024
@jv18creator
Copy link
Contributor

Hi @pujavs I tried to debug this issue more, it seems that on update of user details (PUT) the api still validates the password (even if there's no change in that field userPassword). Please update me if there's change in spec which needs changes on FE side.

Req URL: https://admin-ui-test.gluu.org/jans-config-api/mgt/configuser
Method: PUT
Req body:

{
    "inum": "f176fe0b-8d01-499f-903d-f5ece47e4941",
    "userId": "test1",
    "mail": "[email protected]",
    "displayName": "test1-user-test",
    "jansStatus": "active",
    "givenName": "test1",
    "customAttributes": [
        {
            "name": "sn",
            "multiValued": false,
            "values": [
                "user"
            ]
        },
        {
            "name": "middleName",
            "multiValued": false,
            "values": [
                ""
            ]
        }
    ],
    "dn": "inum=f176fe0b-8d01-499f-903d-f5ece47e4941,ou=people,o=jans"
}

Screenshot 2024-03-27 at 8 10 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-admin-ui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants