Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable minimizing to system tray #87

Open
b2ag opened this issue Aug 5, 2024 · 4 comments
Open

Add option to disable minimizing to system tray #87

b2ag opened this issue Aug 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@b2ag
Copy link

b2ag commented Aug 5, 2024

Hi,

I'd like to have an option to disable PS4 Remote PKG Sender minimizing to the system tray. It previously confused me somewhat that it does this because it didn't ask what it should do on closing the window. Now I switched to Wayland and the system tray icon became unusable (no menu shown when clicking). Previously it was only a small nuisance but now, being unable to easily close the program, it evolved to a real issue. Is it possible to add an option to disable the "minimizing to system tray" feature?

Best

@Gkiokan
Copy link
Owner

Gkiokan commented Sep 2, 2024

The reason it stays in the tray - or on the background - is that the server is running on to provide the Files over the Network. If the application closes at all the server won't serve any files anymore.

If you want to close it via the power button on the right, it will ask you if you want to close it - just to make sure you don't brick an ongoing download on your ps4.

Seems to be a conflict with Wayland. Can you provide some more information?
Does the App stays in your Application bar when you minimize it?

@b2ag
Copy link
Author

b2ag commented Sep 2, 2024

Screencast_20240903_012025.webm

It's weird. On first click it's requesting remote control privileges. I recognize the dialog from trying a virtual / on screen keyboard build for Xorg under Wayland (which actually works).

After granting the request it seems the App doesn't receive a mouse button up event. Doesn't matter which mouse button I use (left or right). So I've already released the button but the icon still looks pressed down and when I move the mouse cursor to one of the other icons next to it or the desktop, the release event seems to suddenly get send.

Nonetheless I would like to see an option for disabling the icon. I'm generally not a fan of tray icons and my PS4 and also my PC crashes often. So I'm under the impression that breaking the connection to the server while a transfer is happening is not a huge deal. I always only open the App to upload stuff and close it right after I've confirmed the install was successful.

The App is also showing the exact same behavior (tray icon and confirm dialog for closing) regardless of if the express server is currently in use or even running.

EDIT: Forgot to answer: yes, it stays in the application / task bar when minimizing, but not when closing the window with the x (not the power button). The later is the annoying situation where I have to kill the App and all possible ongoing downloads I'm not aware of :)

EDIT2: If the transfer is using builtin functionality of the PS4 for downloading content I highly doubt a network outage will lead to a bricked system.

@Gkiokan
Copy link
Owner

Gkiokan commented Sep 3, 2024

Thanks for the detailed insight.

Yeah that bug seems very strange. I will work an option to disable the tray, maybe something like --no-tray.
I can get this into the next update.

I just arrived from vocation there are a couple things to finish off first but I think this shouldn't take long.

@Gkiokan Gkiokan added enhancement New feature or request good first issue Good for newcomers labels Sep 3, 2024
@Gkiokan Gkiokan self-assigned this Sep 3, 2024
@b2ag
Copy link
Author

b2ag commented Sep 3, 2024

Thank you very much. There is no hurry.

I also stopped guessing regarding the bricking and just tested it: if I terminate the Electron process forcefully while a download is running it just results in a "Cannot download" state in the notification area of the PS4 (Hen 9.00, RPI OOP KRBR01111 v1.02). So no bricking involved.

It seems to confuse the App somewhat, as it shows the package as installing when starting up the App again and nothing happens. But a simple click on pause and another on play successfully resumes the transfer where it left of. It works even better than expected.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants