Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming variables won't update overrides #8

Open
GieziJo opened this issue Jun 17, 2021 · 2 comments
Open

Renaming variables won't update overrides #8

GieziJo opened this issue Jun 17, 2021 · 2 comments
Assignees
Labels
critical critical issues that can create loss of work

Comments

@GieziJo
Copy link
Owner

GieziJo commented Jun 17, 2021

Given that a list of variable names defines the overrides, changing the variable name will not propagate to the overrides.
The list could maybe be built when first selecting the object.
Since the values are all reset to the parent's value when setting a parent, it should be enough to just check for further changes down the line. In this case the overrides field would not be needed in the serialization. This could be slower though.

@GieziJo GieziJo added the enhancement New feature or request label Jun 17, 2021
@GieziJo GieziJo self-assigned this Jun 17, 2021
@GieziJo
Copy link
Owner Author

GieziJo commented Jun 17, 2021

We need the overrides list to propagate values to children, so can't get rid of it. Another solution would be to allow the user to manually check for overrides in the whole project at once and fix all entries, printing to the console fields which were not in the override list to make sure everything is done correctly.

@GieziJo
Copy link
Owner Author

GieziJo commented Jun 21, 2021

Check for [FormerlySerialisedAs] attribute on recompile maybe?

@GieziJo GieziJo added critical critical issues that can create loss of work and removed enhancement New feature or request labels Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical critical issues that can create loss of work
Projects
None yet
Development

No branches or pull requests

1 participant