Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank "view" URL in resource grid #8

Closed
pchevali opened this issue Jun 26, 2024 · 3 comments
Closed

Blank "view" URL in resource grid #8

pchevali opened this issue Jun 26, 2024 · 3 comments

Comments

@pchevali
Copy link

pchevali commented Jun 26, 2024

Hi,

I have been testing this contrib app but and I was not able to have the "View" link to follow the detail url.
I only tested with the latest version of geonode (4.3). It seems to me that this part is not working unless by specifying a "subtype" for the external application (I used document and it works).

This seems related to the following lines in geonode mapstore client ( but it hasn't changed since a while ):

https://github.com/GeoNode/geonode-mapstore-client/blob/master/geonode_mapstore_client/client/js/components/ResourceCard/ResourceCard.jsx#L44-L49

Am I missing something here ?

Regards

@ridoo
Copy link
Member

ridoo commented Jun 27, 2024

@pchevali yes .. the problem is, that ATM there is no way to customize UI behaviour at this level of detail via contrib module. This is missing from the documentation, I guess. It is just a one-liner:

https://github.com/Thuenen-GeoNode-Development/geonode-mapstore-client/blob/112b26b45ac8fe85a129625c160a7998a531f8cf/geonode_mapstore_client/client/js/components/DetailsPanel/DetailsPanel.jsx#L157

There is a discussion focussing on dev experience when customizing geonode-mapstore-client which is IMHO expandable.

EDIT: I saw your is pointing to the ResourceCard component which would have to be changed as well (I think, we missed that in the fork I linked above).

@pchevali
Copy link
Author

Ok I understand. So this must be the point where we need to fork the client.
Indeed there are other changes related to externalapplications : https://github.com/search?q=repo%3AThuenen-GeoNode-Development%2Fgeonode-mapstore-client%20externalapplication&type=code

@ridoo
Copy link
Member

ridoo commented Jul 1, 2024

@pchevali I will close this issue here for now.

@ridoo ridoo closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants