-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IncreaseDebt and decreasedebt events are removed they are used by backend . #292
Comments
@harsh-98 they were always coming in pair with nearly identical events in the pool:
|
One pool can have many credit managers. And pools and credit managers are synced separately in backend. Since we have events for withdraw/addcollateral in multicall, it will be nice to still have increase/decrease debt to keep events consistent for all creditfacade operations. The backend already supports. |
The code is frozen so can't add them anyways. |
Still can map pool events uniquely to multicalls since they are emitted in the same tx (between |
frozen for security audit? can u add later? |
The audit is completed, so more like terminally frozen unless we discover a critical security vulnerability. |
Can do. But all four application(gearbox-ws,go-liquidator,third-eye,gpointbot) already supports increaseDebt/decreaseDebt. It will be messy to track on pools and send the info to credit manager logic. |
There is another problem, that i have mentioned in the governance repo. The creditFacade is not set on creditmanager initialization. Gearbox-protocol/governance#11. Previously SetCreditFacade emit has emitted when cm was initialized and creditFacade was set. Now both are missing. Atleast creditFacade field should be set. |
This i will do, as it saves gas for the user. So, worth the effort. But consider the not-initialized creditFacade field on credit manager. |
The text was updated successfully, but these errors were encountered: