Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrowing irm.availableToBorrow might result in an unintended revert #194

Open
lekhovitsky opened this issue Mar 30, 2024 · 0 comments
Open

Borrowing irm.availableToBorrow might result in an unintended revert #194

lekhovitsky opened this issue Mar 30, 2024 · 0 comments

Comments

@lekhovitsky
Copy link
Collaborator

availableToBorrow returns an amount that would move utilization to exactly $U_2$, but trying to borrow this amount would result in BorrowingMoreThanU2ForbiddenException because of use of incorrect sign in calcBorrowRate.
@lekhovitsky lekhovitsky mentioned this issue Jun 20, 2024
Merged
lekhovitsky added a commit that referenced this issue Jun 20, 2024
@lekhovitsky
fix: fixes and optimizations in LinearInterestRateModelV3 (#230)
3969d7f 
In this PR:
* Small fixes in `calcBorrowRate` and `availableToBorrow` to address #194
* Small gas optimizations like removing redundant getters and evaluating some expressions at compile time
lekhovitsky added a commit that referenced this issue Jun 24, 2024
@lekhovitsky
fix: fixes and optimizations in LinearInterestRateModelV3 (#230)
35f1786 
In this PR:
* Small fixes in `calcBorrowRate` and `availableToBorrow` to address #194
* Small gas optimizations like removing redundant getters and evaluating some expressions at compile time
lekhovitsky added a commit that referenced this issue Jul 7, 2024
@lekhovitsky
fix: fixes and optimizations in LinearInterestRateModelV3 (#230)
b3999d8 
In this PR:
* Small fixes in `calcBorrowRate` and `availableToBorrow` to address #194
* Small gas optimizations like removing redundant getters and evaluating some expressions at compile time
@lekhovitsky lekhovitsky mentioned this issue Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lekhovitsky