Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid node16 in github action #1104

Open
mglisse opened this issue Jul 5, 2024 · 0 comments
Open

avoid node16 in github action #1104

mglisse opened this issue Jul 5, 2024 · 0 comments
Labels
CI The Continuous Integration system (github actions, circleCI, ...)

Comments

@mglisse
Copy link
Member

mglisse commented Jul 5, 2024

#1047 and #1103 try to avoid using node20 in the linux github action (and #1103 only touched the build action, not the packaging one), but node16 is going to disappear soon and we will not have a choice. Some options:

  • install a working version of node (possibly statically linked)
  • don't use actions that use node (do we really need node to call git clone?)
  • rebase our Dockerfile on a more recent version of manylinux

The last option is probably the best, but it does mean dropping support for older versions of linux.

@mglisse mglisse added CI The Continuous Integration system (github actions, circleCI, ...) 3.11.0 GUDHI version 3.11.0 and removed 3.11.0 GUDHI version 3.11.0 labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI The Continuous Integration system (github actions, circleCI, ...)
Projects
None yet
Development

No branches or pull requests

1 participant