Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entropy builds useless grid_ #1068

Open
mglisse opened this issue Jun 13, 2024 · 0 comments
Open

Entropy builds useless grid_ #1068

mglisse opened this issue Jun 13, 2024 · 0 comments
Assignees

Comments

@mglisse
Copy link
Member

mglisse commented Jun 13, 2024

Entropy.fit builds a grid_ like many other classes, but it does not really use it, just

  • the first 2 elements to compute step_ in the vector case;
  • the existence of grid_ to test if fit has been called (for __call__).

It looks like something that could be cleaned up at some point.

@MathieuCarriere MathieuCarriere self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants