New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important #37

Open

AbdallahAmmar96 opened this issue Jul 31, 2019 · 0 comments

AbdallahAmmar96 commented Jul 31, 2019

https://github.com/GSG-G7/project5/blob/93ec7f3156141cfc4301f7b8c0a9c2aced529b84/src/controllers/error.js#L1-L14

You require the path module and never use it.
Use camelcase in the names of your functions.
Es-lint is not working
Try to send something descriptive like:
Page Not Found

exports.clientError = (req, res) => {
  res.status(404).send('Page Not Found');
};

exports.serverError = (err, req, res, next) => {
  res.status(500).send('Internal Server Error');
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment