Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #90

Closed
Fatmasiam opened this issue Sep 25, 2019 · 0 comments
Closed

PR #90

Fatmasiam opened this issue Sep 25, 2019 · 0 comments
Assignees
Labels

Comments

@Fatmasiam
Copy link
Collaborator

Fatmasiam commented Sep 25, 2019

When you open the PR :

  1. add it to the related project.
  2. remove any console.log except the console.log on the error file.
  3. remove unrelated files
  4. make sure that your branch is up to date with master
  5. make sure that is working locally
  6. make sure that there are no ESlint issues in your code
  7. code is consistent with an agreed team style

-- put in progress label when you are still working on th PR ..
or make it draft

AND KEEP IN YOUR MIND THAT THE ISSUES IT IS REFERENCE

  • Its didn't take our time to neglect it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants