Username and email columns not unique

[11janci]

Currently in the database the username and email columns are not unique:

lang-mate/server/database/config/dbbuild.sql

Line 17 in bedbb9d

username VARCHAR(255) NOT NULL,

lang-mate/server/database/config/dbbuild.sql

Line 18 in bedbb9d

email VARCHAR(255) NOT NULL,

You are enforcing uniqueness in the code during signup by searching if the username or email already exist in the database:

lang-mate/server/controllers/auth/signup.js

Line 16 in bedbb9d

.then(() => getUserByEmailOrUsername(email, username))

It is better to enforce it directly in the database

username VARCHAR(255) NOT NULL UNIQUE,
email VARCHAR(255) NOT NULL UNIQUE,

• guarantees you won't be able to insert duplicate data (with the code you might introduce some new way of inserting users in the future and forget to enforce the uniqueness)
• allows you to get rid of the initial DB search during signup and just insert right away - if duplicate records already exist, you will get an error

Probably no action necessary, just something to keep in mind.