Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Guide #2

Closed
16 tasks
Oliversw opened this issue Oct 15, 2019 · 0 comments
Closed
16 tasks

Process Guide #2

Oliversw opened this issue Oct 15, 2019 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@Oliversw
Copy link
Collaborator

Oliversw commented Oct 15, 2019

Team:
Project Lead:
PO:

Issues and Labels

Dwyl Labels should be imported into this repo and used when creating issues.

I do not have the right access rights to this repo so you can follow these steps to import the labels:

  1. Visit the Github Label Sync website
  2. Fill the form out according to the screenshot below and click SYNCHRONISE
    Screen Shot 2019-10-18 at 12 15 40 PM

Time Estimating

Time estimation, although hard, its very important. We ask that you try and include a time estimating with Dwyl Labels for every issue, even if you are not sure.
There are 5 built-in time labels:
Screen Shot 2019-10-03 at 4 09 24 PM

  • T1d: 1 day
  • T1h: 1 hour
  • T2h: 2 hours
  • T4h: 4 hours (half-day)
  • T25m: 25min
    When possible, when completing issues please leave a comment with the time actually taken to complete the issue.

Pull Request Checklist

  • Branch is up to date with master
  • The project runs
    • You can download and install locally, and run the project locally
    • All existing and new features run without bugs
    • The build script runs without error
    • (If the project is already deployed to Heroku) the branch to be merged can deploy successfully to Heroku
  • Code is consistent
    • Linter is used, no error messages
    • Code is consistent with an agreed team style
    • Naming of files is consistent with the project (e.g. all files named with camelCase)
  • All tests should pass locally and on Travis
  • No console logs
    • Console.log is only used for crucial system messages (e.g. which port server is on).
    • Any console.logs used for debugging have been removed.
    • Console.error is used in error handling.
    • global.console.log and global.console.error are mocked in tests when needed to avoid littering the console

Linting

Component definition

File structure

Naming Branches

Commit messages

Merging Pull Requests

@Oliversw Oliversw pinned this issue Oct 15, 2019
@Oliversw Oliversw mentioned this issue Oct 18, 2019
@Oliversw Oliversw added the documentation Improvements or additions to documentation label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants