Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade this extension to CKAN 2.8 #50

Open
6 tasks done
avdata99 opened this issue Nov 20, 2019 · 9 comments
Open
6 tasks done

Upgrade this extension to CKAN 2.8 #50

avdata99 opened this issue Nov 20, 2019 · 9 comments
Assignees

Comments

@avdata99
Copy link

avdata99 commented Nov 20, 2019

Test this extension with CKAN 2.8 and test it.

  • Do a manual test to check if it's working
    • Create a DataJSON harvest source
    • Run the harvestr job
    • Analize if the harvested datasets is what we expect.
  • Import tests from datajson fork
  • Add CircleCI configuration (re-use from datopian)

FYI @adborden

@avdata99 avdata99 self-assigned this Nov 20, 2019
@adborden
Copy link

Great, thank you!

@avdata99
Copy link
Author

The ckanext-harvest from GSA is one year old, the CKAN repo has commits from this week.
What of this two should I use @adborden?

@avdata99 avdata99 changed the title Upgrade thie extension to CKAN 2.8 Upgrade this extension to CKAN 2.8 Nov 20, 2019
@avdata99
Copy link
Author

Harvester source created
Selection_2526

Job running
Selection_2527

@avdata99
Copy link
Author

I can see the harvested datasets
image

@avdata99
Copy link
Author

The counter at the left is not working. I saw the new datasets ready.
image

@avdata99
Copy link
Author

I'm comparing a real word harvested dataset with my local CKAN 2.8 + GSA fork:

Real versión:
Selection_2533
Selection_2534

Locally harvested ith GSA fork:
Selection_2532

Some fields seem missing. We need to try with the real template in order to get a better comparison

@adborden
Copy link

adborden commented Nov 20, 2019 via email

@avdata99
Copy link
Author

Tests working in 3 of 4 environments
image

@avdata99
Copy link
Author

Circle CI is working for the four environments.
I think we can close this by now and set new issues if we detect any trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants