From 4a745933858d93a9e56aa05f79ddbd06617338bb Mon Sep 17 00:00:00 2001 From: Richard Geslot Date: Sat, 30 Mar 2024 06:59:18 +0100 Subject: [PATCH 1/3] Update README.md readme - clarify 6.0 --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 4d37c44..8b7237a 100644 --- a/README.md +++ b/README.md @@ -35,9 +35,9 @@ Orochi will aim to maintain support for various version combinations, enabling d Combinations currently supported: | HIP version | CUDA version | Branch | Remarks | -|-------------|--------------|------------------------------------------------------------------------------------------------------------|------------------------------------------------------| -| 5.7 | 12.2 | [release/hip5.7_cuda12.2](https://github.com/GPUOpen-LibrariesAndSDKs/Orochi/tree/release/hip5.7_cuda12.2) | tested and validated | -| 6.0 | 12.2 | [release/hip6.0_cuda12.2](https://github.com/GPUOpen-LibrariesAndSDKs/Orochi/tree/release/hip6.0_cuda12.2) | tested and validated - Windows DLLs not provided yet | +|-------------|--------------|------------------------------------------------------------------------------------------------------------|----------------------------------------------------------| +| 5.7 | 12.2 | [release/hip5.7_cuda12.2](https://github.com/GPUOpen-LibrariesAndSDKs/Orochi/tree/release/hip5.7_cuda12.2) | tested and validated | +| 6.0 | 12.2 | [release/hip6.0_cuda12.2](https://github.com/GPUOpen-LibrariesAndSDKs/Orochi/tree/release/hip6.0_cuda12.2) | tested and validated - HIP Windows DLLs not provided yet | If you need a combination that is currently not supported, open an [Issue](https://github.com/GPUOpen-LibrariesAndSDKs/Orochi/issues). From 4c11f4f7fe0272b6f79e45e1cd1b589b3d6608f5 Mon Sep 17 00:00:00 2001 From: Richard Geslot Date: Sat, 30 Mar 2024 12:27:14 +0100 Subject: [PATCH 2/3] readme - explain contribution PR --- README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/README.md b/README.md index 8b7237a..060a68d 100644 --- a/README.md +++ b/README.md @@ -99,4 +99,14 @@ The source code for the test applications can be found [here](./Test/). ---- +## Contribution + +Feel free to open pull requests. + +You can either target a specific `release/` branch or the `main` branch. + +If it makes sense, your commit will then be propagated in the different `release/` branches by us. + +---- + [1] Yamata no Orochi (ヤマタノオロチ, 八岐大蛇) is a legendary eight-headed and eight-tailed Japanese dragon. From d40b1194ae6b7c3a667f3a20e8a25e9e7b2669f5 Mon Sep 17 00:00:00 2001 From: Richard Geslot Date: Tue, 2 Apr 2024 13:35:10 +0200 Subject: [PATCH 3/3] close of hiprtc DLL was missing --- contrib/hipew/src/hipew.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/contrib/hipew/src/hipew.cpp b/contrib/hipew/src/hipew.cpp index 171eb51..b816d7e 100644 --- a/contrib/hipew/src/hipew.cpp +++ b/contrib/hipew/src/hipew.cpp @@ -557,13 +557,21 @@ static DynamicLibrary dynamic_library_open_find(const char **paths) { return NULL; } -/* Implementation function. */ +// Implementation function. static void hipewHipExit(void) { if (hip_lib != NULL) { - /* Ignore errors. */ + // Ignore errors. dynamic_library_close(hip_lib); hip_lib = NULL; } + + if (hiprtc_lib != NULL) { + // Ignore errors. + dynamic_library_close(hiprtc_lib); + hiprtc_lib = NULL; + } + + return; } #ifdef _WIN32