Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice error reporting to the embedded tools for bad configs #3849

Closed
cmdcolin opened this issue Aug 13, 2023 · 4 comments
Closed

Nice error reporting to the embedded tools for bad configs #3849

cmdcolin opened this issue Aug 13, 2023 · 4 comments

Comments

@cmdcolin
Copy link
Collaborator

Originally posted by @carolinebridge-oicr in #3584 (comment)

@cmdcolin
Copy link
Collaborator Author

probably a good thing to do, moved from the doc thread

@cmdcolin
Copy link
Collaborator Author

note that this could be tricky because the "error handler" would be thrown by the createViewState function so we could not really 'handle' this from the JBrowseReactLinearGenomeView component, since the user passes the return of createViewState to the component, so it would be 'outside of an ErrorHandler that we control'

might just be better to document the issue in storybook docs

@cmdcolin cmdcolin reopened this Aug 29, 2023
@cmdcolin
Copy link
Collaborator Author

didn't intend to close, but could probably close once storybook example is made and i ensure my above assessment is correct...

@cmdcolin
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant