Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in DataAtmGridComp when running CICE6 #1029

Open
zhaobin74 opened this issue Nov 5, 2024 · 1 comment · May be fixed by #1030
Open

Bug in DataAtmGridComp when running CICE6 #1029

zhaobin74 opened this issue Nov 5, 2024 · 1 comment · May be fixed by #1030
Assignees
@zhaobin74

Comments

@zhaobin74
Copy link
Contributor

zhaobin74 commented Nov 5, 2024 •
edited
Loading

When CICE6 is running, there is a SURFSTATE bundle connected between AGCM and OGCM at GCM level.
Currently, DataAtmGridComp terminated all children's imports. This is incorrect and it should allow SURFSTATE to propagate upwards.

Another issue is in finalize where a dealloc should only be called when CICE4 is used.
@zhaobin74 zhaobin74 linked a pull request Nov 5, 2024 that will close this issue
Open
@mfmehari
Copy link
Contributor

mfmehari commented Nov 5, 2024

@zhaobin74 Thank you for making it work with CICE6, it was previously only tested with CICE4. Tested the changes you made with CICE4 and works fine.

@zhaobin74 zhaobin74 self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaobin74 zhaobin74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not terminate SURFSTAT when running with CICE6 GEOS-ESM/GEOSgcm_GridComp
2 participants
@zhaobin74 @mfmehari