Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #5

Open
25 of 29 tasks
FrittenKeeZ opened this issue Aug 19, 2020 · 15 comments
Open
25 of 29 tasks

Roadmap #5

FrittenKeeZ opened this issue Aug 19, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@FrittenKeeZ
Copy link
Owner

FrittenKeeZ commented Aug 19, 2020

0.1.x - 0.2.0

  • Check morph map support
  • Trigger notice on deprecated methods
  • Add owner morph field
  • Make migration command for owner field
  • Add upgrade guide for owner field
  • Remove deprecated methods
  • Add changelog
  • Add support for Laravel 8
  • Prefix compiler optimized functions with \
  • Use strict types where possible
  • Add support for PHP 8

>0.2.x

  • Add callback to Vouchers::redeemable() for conditional checks
  • Remove migration command for owner
  • Change namespace from FrittenKeeZ to Frebs
  • Remove support for PHP 7.1 and 7.2 (maybe 7.3 as well)
  • Add without scopes
  • Switch to Github Actions from Travis
  • Add documentation for vouchers with fixed codes like FREEBIE2021
    • withCode
    • withCounter
    • withCounterStep
    • withCounterSeparator
    • withCounterPadding
    • withCodeFormatter
  • Add unredeem() and unredeemable() helper methods
  • Add primary key to all tables
  • Make all migrations publishable
  • Add support for Laravel 10
  • Remove support for Laravel 5.x
  • Remove support for PHPUnit 7/8
  • Replace PHP CS Fixer with Laravel Pint

>1.x

  • Remove support for PHP 7.x
  • Remove support for Laravel 6/7
  • Update PHPUnit configuration
  • Replace unit tests with PEST
@FrittenKeeZ FrittenKeeZ added the enhancement New feature or request label Aug 19, 2020
@FrittenKeeZ FrittenKeeZ self-assigned this Aug 19, 2020
@zaghadon
Copy link

zaghadon commented Aug 28, 2022

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

@FrittenKeeZ
Copy link
Owner Author

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

Only that it's shorter and simpler - regardless it would be a breaking change and a major dev version if I do, but I'm aiming to do it for 1.0.0

@zaghadon
Copy link

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

@FrittenKeeZ
Copy link
Owner Author

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

I don't really have any other noteworthy packages, but I would change the namespace across the board, yes.

@zaghadon
Copy link

Ohh, okay. That's justifiable.

Hopefully this would be effectively documented. Let me know when you want to make this change so I could help implement and document it.

@mgamal92
Copy link
Contributor

mgamal92 commented Feb 14, 2023

@FrittenKeeZ Are you still working on open tasks ?

@FrittenKeeZ
Copy link
Owner Author

@mgamal92 I want to get back and update this for Laravel 10 and probably remove Laravel 5 in the process - there's been a lot of other projects taking my time, but I want to progress this one soon, and Laravel 10 is a good excuse :)

@mgamal92
Copy link
Contributor

@FrittenKeeZ May I help you in this package and work on some tasks ? so we can arrange that between us

@FrittenKeeZ
Copy link
Owner Author

@mgamal92 Sure, just open a PR

@mgamal92
Copy link
Contributor

@FrittenKeeZ Sure but are there some tasks which have more priority ?

@FrittenKeeZ
Copy link
Owner Author

@mgamal92 I've just updated the roadmap, but you can just choose what you feel like

@mgamal92
Copy link
Contributor

@FrittenKeeZ OK great

@addgod
Copy link

addgod commented Mar 7, 2023

I would consider changing the "withEntities" to take a collection or array of entities. This would make it much easier to use programmatically, when you chain the facade.

Also it would be great if the withStartTime would take a null as well, so you do not have to wrap it in a if sentence first to make sure it exists, if you are generating these from some user input. Same with withEndTime.

@jn-devops
Copy link

Will there be an update to support the latest Laravel framework e.g. 11.10.0?

@FrittenKeeZ
Copy link
Owner Author

@jn-devops yes, I've thought about removing support for everything below Laravel 9 and update tests accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants