Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing passwords when logged in is impossible with this plugin #50

Open
Flole998 opened this issue Mar 7, 2024 · 1 comment · May be fixed by #51
Open

Changing passwords when logged in is impossible with this plugin #50

Flole998 opened this issue Mar 7, 2024 · 1 comment · May be fixed by #51
Labels
bug Something isn't working

Comments

@Flole998
Copy link

Flole998 commented Mar 7, 2024

Hi everyone, I am having an issue with the recaptcha plugin and I already identified the issue in the sourcecode. The issue is, that when I am logged in and I want to change my password, Flarum basically does a password reset. However, that password reset needs a recaptcha when the plugin is active. The "bad" validator is added in

if ($flarumValidator instanceof ForgotPasswordValidator && $this->settings->get('fof-recaptcha.forgot')) {
$validator->addRules([
'g-recaptcha-response' => ['required', 'recaptcha'],
. That needs to be changed so the validator is only added if there is no user logged in currently, or the captcha needs to be added to the ChangePasswordModal.

@Flole998 Flole998 added the bug Something isn't working label Mar 7, 2024
Flole998 added a commit to Flole998/recaptcha that referenced this issue Mar 7, 2024
@Flole998 Flole998 linked a pull request Mar 7, 2024 that will close this issue
@giuliomoro
Copy link

giuliomoro commented Sep 9, 2024

+ 1 . @davwheat @dsevillamartin (tagging you because you have the most recent commits on the repo) can you have a look ? There's a pending PR #51 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants