Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing the pkgconfig file(.pc) #485

Open
taozuhong opened this issue Mar 3, 2023 · 7 comments
Open

Missing the pkgconfig file(.pc) #485

taozuhong opened this issue Mar 3, 2023 · 7 comments

Comments

@taozuhong
Copy link
Contributor

I'm not sure the Libs.Private is right, pls help me correct it

# 
#  pkg_config.pc.in
#
#  pkg_config configuration file 
#  For a detailed description of options, please visit
#  Dan Nicholson’s Guide to pkg-config (http://www.freedesktop.org/wiki/Software/pkg-config/)
#

prefix=/ucrt64
includedir=${prefix}/include/freetds/
libdir=${prefix}/lib/

Name: libfreetds
Version: 1.3.15
Description: A free implementation of TDS protocol
Requires: 
Requires.private: libssl libcrypto
Cflags: -I${includedir}
Libs: -L${libdir} -lct -lsybdb
Libs.private: -lws2_32 -ladvapi32 -lkernel32 -lcrypt32 -lsecur32
@freddy77
Copy link
Contributor

I saw the linked issues on MINGW-packages. It's not clear where this need is coming. Some comments:

  • by default there's no include/freetds installed directory, files are installed in include;
  • you are pointing to 2 libraries, not one;
  • the proposed file is Windows specific;
  • given Requires.private are Libs.private necessary?

It seems the .pc files would be needed because MingW packaging is changing the defaults so IMO they should be just in MingW.

@taozuhong
Copy link
Contributor Author

Yes, it's specific for Windows MSYS2.

Split pc file into sqlserver.pc and sybase.pc ?

@freddy77
Copy link
Contributor

freddy77 commented Oct 6, 2023

I would suggest dblib.pc and ctlib.pc. FreeTDS provides 3 libraries: DB-library, CT-library and ODBC. ODBC is not supposed to be used directly but through the ODBC driver manager (like unixODBC or iODBC), the others are used independently.

@taozuhong
Copy link
Contributor Author

Great idea, let it be born.

@taozuhong
Copy link
Contributor Author

#517 will fix this issue with CMake.
not complete yet with makefile.

@taozuhong
Copy link
Contributor Author

I found that Arch Linux package missing the pkg-config file(.pc) too.

@freddy77
Copy link
Contributor

freddy77 commented Apr 3, 2024

I found that Arch Linux package missing the pkg-config file(.pc) too.

which one?

By the way, one problem is that neither Autoconf not CMake are using pkg-config so the dependency you are generating are assuming they are present while we are not checking them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants