Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use julia v1.11 as default in CI and Docs #371

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Use julia v1.11 as default in CI and Docs #371

merged 5 commits into from
Oct 22, 2024

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Oct 8, 2024

Move CI to use Julia v1.11; drop appveyor in favor of GitHub Actions.

@navidcy navidcy added the tests label Oct 22, 2024
@navidcy navidcy requested a review from jbisits October 22, 2024 04:01
@jbisits
Copy link
Collaborator

jbisits commented Oct 22, 2024

The changes all look good!

Just this error

Grid tests: Error During Test at /var/lib/buildkite-agent/builds/gpuci-1/julialang/fourierflows-dot-jl/test/runtests.jl:107
--
  | Test threw exception
  | Expression: test_plan_flows_fftrfft(dev, T = T)
  | UndefVarError: `cCuFFTPlan` not defined in `CUDA.CUFFT`
  | Suggestion: check for spelling errors or missing imports.

which does not appear to have been occurring previously?

The full function for this test on the GPU is

https://github.com/FourierFlows/FourierFlows.jl/blob/1c412b9708fd5a22a429b43dc51b50b6e5dd7bba/test/test_grid.jl#L188C1-L201C4

@navidcy navidcy merged commit 71ec327 into main Oct 22, 2024
10 checks passed
@navidcy navidcy deleted the ncc/julia-v1.11 branch October 22, 2024 04:57
@navidcy navidcy mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants