refactor: Simplify the internal implementation of KurtResult. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of KurtResult was handling two different kinds of listeners: full stream listeners and final event listeners. This commit removes a bunch of internal fields related to tracking state for final event listeners, unifying it with the mechanism for full stream listeners, using a simple function to convert a full stream listener to a final event listener.
InfraK
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of KurtResult was handling two different kinds of listeners: full stream listeners and final event listeners.
This commit removes a bunch of internal fields related to tracking state for final event listeners, unifying it with the mechanism for full stream listeners, using a simple function to convert a full stream listener to a final event listener.