Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-Axis Overflow using curvyType=natural with CartesianChart #456

Open
joacohoyos opened this issue Dec 16, 2024 · 1 comment
Open

Y-Axis Overflow using curvyType=natural with CartesianChart #456

joacohoyos opened this issue Dec 16, 2024 · 1 comment

Comments

@joacohoyos
Copy link

joacohoyos commented Dec 16, 2024

Describe Your Environment

What version of victory-native-xl are you using? (can be found by running npm list --depth 0 victory-native)
└── [email protected]

What version of React and React Native are you using?

  • "react": "18.3.1"
  • "react-native": "0.76.3"

What version of Reanimated and React Native Skia are you using?

  • "@shopify/react-native-skia": "1.5.0"
  • "react-native-reanimated": "~3.16.1"

Are you using Expo or React Native CLI?

What platform are you on? (e.g., iOS, Android)
IOS

Describe the Problem

Same as the following discussion:
FormidableLabs/victory#2133
Depending the data source sometimes the chart overflows on natural curveType.

Here there is a data source that I was able to reproduce with
https://gist.github.com/joacohoyos/27c6ae155d955e9c47ca3fd7f2459964

Expected behavior: [What you expect to happen]
Chart correctly respects the chart limits
Actual behavior: [What actually happens]
Chart overflows on the Y axis

Additional Information

@akpekig
Copy link

akpekig commented Dec 16, 2024

Use monotoneX to reflect actual data. It isn't documented yet on Victory Native, but is a valid CurveType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants