Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move application definitions into individual definition files #459

Closed
binglot opened this issue Feb 17, 2022 · 5 comments
Closed

Move application definitions into individual definition files #459

binglot opened this issue Feb 17, 2022 · 5 comments
Assignees

Comments

@binglot
Copy link
Contributor

binglot commented Feb 17, 2022

I'd like to suggest 2 changes:

  • I think having a label for Hadoop is unnecessary, so I'd remove it.
  • I'd move the Hadoop-, Tomcat-, Containerd- and Docker-related definitions from their own files into the Applications yaml file. There's also the Kubernetes file could potentially also go into the Applications yaml file but the file is large enough that I'd keep it separate.
@sydp
Copy link
Contributor

sydp commented Jul 21, 2022

Have created a new PR for third party Linux based servers. We could move Hadoop, Tomcat into this. WDYT?

#521

@joachimmetz
Copy link
Member

@sydp @binglot what is the status of this? Give #512 was merged is this completed?

@sydp
Copy link
Contributor

sydp commented Feb 26, 2024

Discussed with @binglot OOB and this issue was a suggestion to reorganise a number of application definitions into their own yaml file and since this has not yet happened, the issue has not been addressed.

@sydp sydp removed their assignment Feb 26, 2024
@joachimmetz joachimmetz changed the title Unify Application-related definitions Move application definitions into individual definition files Feb 26, 2024
@joachimmetz
Copy link
Member

@sydp I would recommend a proposal/documentation on how to organize such files, so it can be enforced going forwards similar to a style guide (maybe by the validator?).

@joachimmetz
Copy link
Member

Per chat with @sydp mostly cosmetic changes, will revisit in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants